Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test environments inherit and modify local genesis.json #5200

Merged
merged 3 commits into from
Oct 31, 2024
Merged

fix: test environments inherit and modify local genesis.json #5200

merged 3 commits into from
Oct 31, 2024
+117 −49

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Oct 29, 2024 •
edited
Loading

Context

#5027 made test environments generate genesis.json by themselves, which took away the means to reflect local genesis.json changes to the test environments

Solution

Partially revert #5027 for docker compose and test_env.py to inherit and modify local genesis.json

Review notes

  • executor wasm_dir paths are resolved at the modified genesis.json. They aren't affected by the second resolution in RawGenesisTransaction::from_path during kagami genesis sign

Checklist

  • I've read CONTRIBUTING.md.
  • All review comments have been resolved.
  • All CI checks pass.

@github-actions github-actions bot added the config-changes Changes in configuration and start up of the Iroha label Oct 29, 2024
@github-actions GitHub Actions
Copy link

@BAStos525

@s8sato s8sato self-assigned this Oct 29, 2024
@s8sato s8sato marked this pull request as ready for review October 29, 2024 12:52
@s8sato
fix: test environments inherit and modify local genesis.json
29328a7 
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato enabled auto-merge (squash) October 29, 2024 14:03
@s8sato s8sato merged commit 007d2e3 into hyperledger-iroha:main Oct 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x009922 0x009922 0x009922 approved these changes

@mversic mversic mversic approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@s8sato s8sato

Labels
config-changes Changes in configuration and start up of the Iroha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s8sato @0x009922 @mversic